AGENT-1473: add InternalReleaseImageDegraded state type for MachineConfigNodeStatus Conditions field by andfasano · Pull Request #2777 · openshift/api

andfasano · 2026-03-24T09:05:09Z

This value will be used to indicate the availability or not of the node local InternalReleaseImage registry.

Related to #2611

openshift-ci-robot · 2026-03-24T09:05:11Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-03-24T09:05:14Z

@andfasano: This pull request references AGENT-1473 which is a valid jira issue.

Details

In response to this:

This value will be used to indicate the availability or not of the node local InternalReleaseImage registry.

Related to #2611

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-03-24T09:05:15Z

Hello @andfasano! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

coderabbitai · 2026-03-24T09:05:25Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b150d29e-2501-4efa-931b-a00cc2ab02eb

📥 Commits

Reviewing files that changed from the base of the PR and between 0e4a016 and 458cdaf.

⛔ Files ignored due to path filters (12)

machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-Hypershift-CustomNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-Hypershift-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-Hypershift-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-CustomNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
machineconfiguration/v1/zz_generated.featuregated-crd-manifests/machineconfignodes.machineconfiguration.openshift.io/AAA_ungated.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
machineconfiguration/v1/zz_generated.featuregated-crd-manifests/machineconfignodes.machineconfiguration.openshift.io/ImageModeStatusReporting.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
machineconfiguration/v1/zz_generated.featuregated-crd-manifests/machineconfignodes.machineconfiguration.openshift.io/IrreconcilableMachineConfig.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**
machineconfiguration/v1/zz_generated.featuregated-crd-manifests/machineconfignodes.machineconfiguration.openshift.io/NoRegistryClusterInstall.yaml is excluded by !**/zz_generated.featuregated-crd-manifests/**

📒 Files selected for processing (10)

machineconfiguration/v1/types_machineconfignode.go
machineconfiguration/v1/zz_generated.swagger_doc_generated.go
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Default.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Hypershift-CustomNoUpgrade.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Hypershift-DevPreviewNoUpgrade.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Hypershift-TechPreviewNoUpgrade.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-OKD.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-CustomNoUpgrade.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-DevPreviewNoUpgrade.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-TechPreviewNoUpgrade.crd.yaml

✅ Files skipped from review due to trivial changes (5)

payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Default.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Hypershift-DevPreviewNoUpgrade.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-SelfManagedHA-CustomNoUpgrade.crd.yaml
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Hypershift-CustomNoUpgrade.crd.yaml
machineconfiguration/v1/zz_generated.swagger_doc_generated.go

🚧 Files skipped from review as they are similar to previous changes (2)

machineconfiguration/v1/types_machineconfignode.go
payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-Hypershift-TechPreviewNoUpgrade.crd.yaml

📝 Walkthrough

Walkthrough

This change introduces support for a new machine configuration node condition type called InternalReleaseImageDegraded. A new StateProgress enum constant is added to the Go types to represent this state. Documentation is updated across multiple CustomResourceDefinition manifests to list this condition as a valid type available when the NoRegistryClusterInstall feature gate is enabled. Generated Swagger documentation is also updated to reflect the new condition type. No schema structure modifications or validation logic changes were made.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.3)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-03-24T09:05:41Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yuqi-zhang · 2026-03-24T15:01:22Z

machineconfiguration/v1/types_machineconfignode.go

 // +kubebuilder:subresource:status
 // +openshift:api-approved.openshift.io=https://github.com/openshift/api/pull/2255
 // +openshift:file-pattern=cvoRunLevel=0000_80,operatorName=machine-config,operatorOrdering=01
+// +openshift:enable:FeatureGate=MachineConfigNodes


We removed this in #2715 . Did you mean to try to attach the NoRegistryClusterInstall FG?

🤔 Interesting, I didn't notice that it was automatically added when I ran the make update command

…atus Conditions field This value will be used to indicate the availability or not of the node local InternalReleaseImage registry

openshift-ci · 2026-03-24T18:31:44Z

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

yuqi-zhang · 2026-03-25T00:29:56Z

Should be fine as is. The condition should be gated in the MCO code itself right, so this change should be safe.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 24, 2026

openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 24, 2026

openshift-ci bot requested review from JoelSpeed and cheesesashimi March 24, 2026 09:05

yuqi-zhang reviewed Mar 24, 2026

View reviewed changes

added InternalReleaseImageDegraded state type for MachineConfigNodeSt…

458cdaf

…atus Conditions field This value will be used to indicate the availability or not of the node local InternalReleaseImage registry

andfasano force-pushed the iri-missing-status-fields-machineconfignode branch from 0e4a016 to 458cdaf Compare March 24, 2026 18:06

openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AGENT-1473: add InternalReleaseImageDegraded state type for MachineConfigNodeStatus Conditions field#2777

AGENT-1473: add InternalReleaseImageDegraded state type for MachineConfigNodeStatus Conditions field#2777
andfasano wants to merge 1 commit intoopenshift:masterfrom
andfasano:iri-missing-status-fields-machineconfignode

andfasano commented Mar 24, 2026

Uh oh!

openshift-ci-robot commented Mar 24, 2026

Uh oh!

openshift-ci-robot commented Mar 24, 2026 •

edited by openshift-ci bot

Loading

Uh oh!

openshift-ci bot commented Mar 24, 2026

Uh oh!

coderabbitai bot commented Mar 24, 2026 •

edited

Loading

Walkthrough

Uh oh!

openshift-ci bot commented Mar 24, 2026

Uh oh!

yuqi-zhang Mar 24, 2026

Uh oh!

andfasano Mar 24, 2026

Uh oh!

openshift-ci bot commented Mar 24, 2026

Uh oh!

yuqi-zhang commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

andfasano commented Mar 24, 2026

Uh oh!

openshift-ci-robot commented Mar 24, 2026

Uh oh!

openshift-ci-robot commented Mar 24, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Mar 24, 2026

Uh oh!

coderabbitai bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

openshift-ci bot commented Mar 24, 2026

Uh oh!

yuqi-zhang Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

andfasano Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Mar 24, 2026

Uh oh!

yuqi-zhang commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

openshift-ci-robot commented Mar 24, 2026 •

edited by openshift-ci bot

Loading

coderabbitai bot commented Mar 24, 2026 •

edited

Loading